Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seal JsonSourceGenerationOptionsAttribute #56317

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Jul 26, 2021

Missed in the original implementation. Related to #56206. Not a breaking change because sub-classing the attribute currently has no effect.

@layomia layomia added this to the 6.0.0 milestone Jul 26, 2021
@layomia layomia self-assigned this Jul 26, 2021
@ghost
Copy link

ghost commented Jul 26, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Missed in the original implementation. Related to #56206. Not a breaking change because sub-classing the attribute currently has no effect.

Author: layomia
Assignees: layomia
Labels:

area-System.Text.Json

Milestone: 6.0.0

@dotnet-issue-labeler

This comment has been minimized.

@layomia layomia merged commit 09e1608 into dotnet:main Jul 26, 2021
@layomia layomia deleted the SealOptionsAttribute branch July 26, 2021 20:02
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants